Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CKEDITOR.tools.convertToPx should be able to return negative values #2224

Closed
engineering-this opened this issue Jul 13, 2018 · 0 comments
Closed

CKEDITOR.tools.convertToPx should be able to return negative values #2224

engineering-this opened this issue Jul 13, 2018 · 0 comments
Labels
changelog:api A changelog entry should be put in the API section of the changelog. status:confirmed An issue confirmed by the development team. target:major Any docs related issue that should be merged into a major branch. type:feature A feature request.
Milestone
4.11.0

Comments

@engineering-this
Copy link
Contributor

Type of report

Feature request

Provide description of the new feature

CKEDITOR.tools.convertToPx should be able to return negative values. Currently negatives are treated as wrong input, and returns are bugged as in #2223.

Example

CKEDITOR.tools.convertToPx( '-10px' ) // Should return 10.
@engineering-this engineering-this added type:feature A feature request. status:confirmed An issue confirmed by the development team. labels Jul 13, 2018
@mlewand mlewand added target:major Any docs related issue that should be merged into a major branch. changelog:api A changelog entry should be put in the API section of the changelog. labels Jul 16, 2018
@mlewand mlewand mentioned this issue Jul 16, 2018
Merged
2 tasks
engineering-this added a commit that referenced this issue Jul 16, 2018
@engineering-this
(#2224) all convertToPx negative numbers feature version references n…
b945f26 
…ow point to 4.11.0 version
Comandeer pushed a commit that referenced this issue Jul 18, 2018
@engineering-this @Comandeer
(#2224) all convertToPx negative numbers feature version references n…
7852ad5 
…ow point to 4.11.0 version
@Comandeer Comandeer added this to the 4.11.0 milestone Jul 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
changelog:api A changelog entry should be put in the API section of the changelog. status:confirmed An issue confirmed by the development team. target:major Any docs related issue that should be merged into a major branch. type:feature A feature request.
Projects
None yet
Milestone
4.11.0
Development

No branches or pull requests
3 participants
@Comandeer @mlewand @engineering-this