Fix bug with scrolling page after emoji group click #2587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlewand
suggested changes
Nov 8, 2018
| @@ -115,7 +115,7 @@ | |||
|
|
|||
| assert.areSame( 0, emojiBlock.$.scrollTop, 'Emoji elements should be scrolled to the top.' ); | |||
|
|
|||
| doc.findOne( 'a[href="#flags"]' ).$.click(); | |||
| doc.findOne( 'a[title="Flags"]' ).$.click(); | |||
There was a problem hiding this comment.
Since you're using title (that is localized) you have to force editor language to English. Otherwise it might get set to user-agent language, and test will fail because of translations.
|
|
||
| 1. Open emoji dropdown. | ||
| 2. Click into emoji group. | ||
| ### Expected: |
There was a problem hiding this comment.
Expected / unexpected headers are not followed with a colon.
tests/plugins/emoji/dropdown.js
Outdated
| doc.findOne( 'a[title="Flags"]' ).$.click(); | ||
| assert.areEqual( scrollPosition, win.getScrollPosition().y, 'Window should not be scrolled down after clicking into navigation' ); | ||
| } | ||
| finally { |
There was a problem hiding this comment.
finally should be in the same line with a previous curly brace.
tests/plugins/emoji/dropdown.js
Outdated
| parentHeight; | ||
|
|
||
| // There is need to resize iframe with test run from dashboard. To prevent situation, | ||
| // where foccusing element will additionaly scroll page |
There was a problem hiding this comment.
Suggested change
| // where foccusing element will additionaly scroll page | |
| // where focusing element will additionally scroll page |
typo
Comandeer
requested changes
Nov 8, 2018
…find elements in emoji dropdown.
…default event to not scroll page. Merge listeners into one function.
|
Rebased onto latest master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Bug fix
This PR contains
What changes did you make?
Close #2571