Page break support for paste from word #2602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacekbogdanski
force-pushed
the
t/2598
branch
from
35b0fc0
to
0301831
Compare
Comandeer
requested changes
Nov 14, 2018
| 'br': function( element ) { | ||
| var styles = tools.parseCssText( element.attributes.style ); | ||
|
|
||
| if ( editor.plugins.pagebreak && styles[ 'page-break-before' ] === 'always' ) { |
There was a problem hiding this comment.
editor.plugins.pagebreak should be moved to the beginning of the function, as an early return. If the plugin is no loaded, there is no need to even parse element's styles.
Comandeer
requested changes
Nov 20, 2018
| @@ -0,0 +1,27 @@ | |||
| @bender-tags: feature, 4.12.0, pastefromword | |||
Comandeer
requested changes
Nov 23, 2018
jacekbogdanski
force-pushed
the
t/2598
branch
from
39b6e76
to
7e9bc1a
Compare
|
It looks like Safari PFW contains a different tag to recognize page breaks. |
Comandeer
requested changes
Jan 3, 2019
jacekbogdanski
force-pushed
the
t/2598
branch
from
7e9bc1a
to
43bdf1b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
New feature
Does your PR contain necessary tests?
All patches which change the editor code must include tests. You can always read more
on PR testing,
how to set the testing environment and
how to create tests
in the official CKEditor documentation.
This PR contains
What changes did you make?
I think that it makes the most sense to introduce this feature as optional if
pagebreakplugin is available. Requiringpagebreakplugin bypastefromwordwill force users to usepagebreakplugin which may not be wanted behavior (especially that it changes toolbar).Closes #2598