Merge pull request #350 from ckeditor/i/342

Fix: Aligned `window.CKEDITOR_VERSION` type with the community typings. Closes #342.

package.json

@@ -27,6 +27,7 @@
     "@angular/platform-browser": "^13.3.11",
     "@angular/platform-browser-dynamic": "^13.3.11",
     "@angular/router": "^13.3.11",
+    "@types/ckeditor__ckeditor5-utils": ">=28.0.14",
     "core-js": "^3.21.1",
     "rxjs": "^6.5.5",
     "tslib": "^2.0.3",

src/ckeditor/ckeditor.component.spec.ts

@@ -24,13 +24,13 @@ describe( 'CKEditorComponent', () => {
 		beforeEach( () => {
 			spyOn( console, 'warn' );
 
-			CKEDITOR_VERSION = window.CKEDITOR_VERSION;
+			CKEDITOR_VERSION = ( window as any ).CKEDITOR_VERSION;
 		} );
 
 		afterEach( () => {
 			fixture.destroy();
 
-			window.CKEDITOR_VERSION = CKEDITOR_VERSION;
+			( window as any ).CKEDITOR_VERSION = CKEDITOR_VERSION;
 		} );
 
 		it( 'should create', () => {
@@ -42,7 +42,7 @@ describe( 'CKEditorComponent', () => {
 		} );
 
 		it( 'should print a warning if the "window.CKEDITOR_VERSION" variable is not available', () => {
-			delete window.CKEDITOR_VERSION;
+			delete ( window as any ).CKEDITOR_VERSION;
 
 			fixture = TestBed.createComponent( CKEditorComponent );
 			component = fixture.componentInstance;
@@ -52,7 +52,7 @@ describe( 'CKEditorComponent', () => {
 		} );
 
 		it( 'should print a warning if using CKEditor 5 in version lower than 34', () => {
-			window.CKEDITOR_VERSION = '30.0.0';
+			( window as any ).CKEDITOR_VERSION = '30.0.0';
 
 			fixture = TestBed.createComponent( CKEditorComponent );
 			component = fixture.componentInstance;
@@ -62,7 +62,7 @@ describe( 'CKEditorComponent', () => {
 		} );
 
 		it( 'should not print any warning if using CKEditor 5 in version 34 or higher', () => {
-			window.CKEDITOR_VERSION = '34.0.0';
+			( window as any ).CKEDITOR_VERSION = '34.0.0';
 
 			fixture = TestBed.createComponent( CKEditorComponent );
 			component = fixture.componentInstance;

src/ckeditor/ckeditor.component.ts

@@ -3,9 +3,11 @@
  * For licensing, see LICENSE.md.
  */
 
+import type { version } from 'ckeditor__ckeditor5-utils';
+
 declare global {
 	interface Window {
-		CKEDITOR_VERSION?: string;
+		CKEDITOR_VERSION: typeof version;
 	}
 }
 

src/ckeditor/ng-package.json

@@ -2,5 +2,9 @@
   "lib": {
     "entryFile": "./index.ts"
   },
+  "allowedNonPeerDependencies": [
+    "@ckeditor/ckeditor5-watchdog",
+    "@types/ckeditor__ckeditor5-utils"
+  ],
   "dest": "../../dist"
 }

src/ckeditor/package.json

@@ -18,11 +18,14 @@
     "ckeditor5",
     "ckeditor 5"
   ],
+  "dependencies": {
+    "@ckeditor/ckeditor5-watchdog": ">=34.0.0",
+    "@types/ckeditor__ckeditor5-utils": ">=28.0.14"
+  },
   "peerDependencies": {
     "@angular/core": ">=13.0.0",
     "@angular/common": ">=13.0.0",
     "@angular/forms": ">=13.0.0",
-    "@ckeditor/ckeditor5-watchdog": ">=34.0.0",
     "rxjs": ">=6.0.0"
   },
   "author": "CKSource (http://cksource.com/)",