Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Windows Build #26
How does it break now? It may be something simple, but we didn't test it on Windows yet so I really don't know.
As for Windows support in general, I guess it's a high time that we provide it for at least the builds. Support for the entire development environment is something bigger and far less developers will need it so it may wait (I hope).
About half of the year ago I tested our test tools on Windows and one issue which I found was invalid regexp for Windows.
I guess the same problem can occur here. When we made a config file, we assumed that Webpack will be executed on Unix. So regexps have been written for Unix paths.
If we fix the regexp for Windows, most probably the problem won't occur anymore. It's worth checking.
Tried few things.
This is the result of default build as "npm run build"
Later i changed create entry file script to this; "node bin/create-entry-file.js".
And eventually i checked shell script, saw webpack, and changed "build-ckeditor" command to "webpack".
This is the the error i got.
I think we are now in same page with @pomek
We can easily skip first 2 problems just by changing these lines. But cgywin required for shell script. Tried on Mac and Windows, worked well.
So only problem probably regexp.
@onurozkan, great! Thanks for the details. Could you make a PR to this package with your changes?
We'll handle the regexp in https://github.com/ckeditor/ckeditor5-dev/tree/master/packages/ckeditor5-dev-webpack-plugin and see if something's left. @pomek, could you look into it?