Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make webpack plugin being able to run inside the ckeditor5-* package #303

Merged
merged 1 commit into from
Nov 9, 2017

Conversation

ma2ciek
Copy link
Contributor

@ma2ciek ma2ciek commented Nov 9, 2017

Suggested merge commit message (convention)

Fix: Made webpack plugin being able to run inside the ckeditor5-* package. Closes #302.

@ma2ciek
Copy link
Contributor Author

ma2ciek commented Nov 9, 2017

I'm considering moving functions, that are inside replacetcalls to TranslationService class for being able to test them.

@pomek
Copy link
Member

pomek commented Nov 9, 2017

Would be good to have at least one test which checks whether the paths are correct. But I don't know how much changes it requires.

@ma2ciek
Copy link
Contributor Author

ma2ciek commented Nov 9, 2017

@pomek. I'm working on the ckeditor/ckeditor5#624, so I'll be probably rewriting those part to make TranslationService and the plugin's core part more generic. So I think that we can wait for the incoming changes before rewriting that part for tests. I'll keep that in mind.

@pomek
Copy link
Member

pomek commented Nov 9, 2017

I will check whether builds work. If nothing will crash, I'll merge.

@pomek
Copy link
Member

pomek commented Nov 9, 2017

Error: original.line and original.column are not numbers -- you probably meant to omit the original mapping entirely and only map the generated position. If so, pass null for the original mapping instead of an object with empty or null values.

But it isn't a part of this ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants