Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

t/3: The data controller should be initialized in DecoupledEditor.create #4

Merged
merged 1 commit into from
Mar 13, 2018

Conversation

oleq
Copy link
Member

@oleq oleq commented Mar 13, 2018

Suggested merge commit message (convention)

Fix: The data controller should be initialized in DecoupledEditor.create(). Closes ckeditor/ckeditor5#2241.

@oleq oleq requested a review from oskarwrobel March 13, 2018 12:59
@coveralls
Copy link

Pull Request Test Coverage Report for Build 22

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 20: 0.0%
Covered Lines: 58
Relevant Lines: 58

💛 - Coveralls

@oskarwrobel
Copy link
Contributor

Clever test :)

@oskarwrobel oskarwrobel merged commit bf0b990 into master Mar 13, 2018
@oskarwrobel oskarwrobel deleted the t/3 branch March 13, 2018 13:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DataController#init method should be used in create chain
3 participants