'DowncastWriter#rename()' method params order changed.

ckeditor · Sep 10, 2018 · e50028e · e50028e
1 parent 7be0e23
commit e50028e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/view/downcastwriter.js b/src/view/downcastwriter.js
@@ -908,10 +908,10 @@ export default class DowncastWriter {
 	 *
 	 * Since this function creates a new element and removes the given one, the new element is returned to keep reference.
 	 *
-	 * @param {module:engine/view/containerelement~ContainerElement} viewElement Element to be renamed.
 	 * @param {String} newName New name for element.
+	 * @param {module:engine/view/containerelement~ContainerElement} viewElement Element to be renamed.
 	 */
-	rename( viewElement, newName ) {
+	rename( newName, viewElement ) {
 		const newElement = new ContainerElement( newName, viewElement.getAttributes() );
 
 		this.insert( Position.createAfter( viewElement ), newElement );

diff --git a/tests/view/downcastwriter/rename.js b/tests/view/downcastwriter/rename.js
@@ -24,7 +24,7 @@ describe( 'DowncastWriter', () => {
 		it( 'should rename given element by inserting a new element in the place of the old one', () => {
 			const text = foo.getChild( 0 );
 
-			writer.rename( foo, 'bar' );
+			writer.rename( 'bar', foo );
 
 			const bar = root.getChild( 0 );
 
@@ -35,7 +35,7 @@ describe( 'DowncastWriter', () => {
 		} );
 
 		it( 'should return a reference to the inserted element', () => {
-			const bar = writer.rename( foo, 'bar' );
+			const bar = writer.rename( 'bar', foo );
 
 			expect( bar ).to.equal( root.getChild( 0 ) );
 		} );