This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
Clean-up model, document and controllers API #1215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes Unknown when pulling 2ef1319 on t/1208 into ** on master**. |
|
Changes Unknown when pulling f864e43 on t/1208 into ** on master**. |
|
The change looks fine. However Friday before Christmas, 17:00 sounds like a terrible moment for a multirepo merge, so let's wait a moment :) |
pjasiun
approved these changes
Dec 22, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Other: Cleaned up model, document and controllers API. Closes ckeditor/ckeditor5#4220.
Additional information
BREAKING CHANGE: Moved tranformation imports from
DocumenttoModelBREAKING CHANGE: Moved
document.transformDeltas()tomodel.transformDeltas()BREAKING CHANGE: Moved
dataController.insertContent()tomodel.insertContent()BREAKING CHANGE: Moved
dataController.deleteContent()tomodel.deleteContent()()BREAKING CHANGE: Moved
dataController.modifySelectiontomodel.modifySelection()BREAKING CHANGE: Moved
dataController.getSelectedContenttomodel.getSelectedContent()BREAKING CHANGE: Moved
dataController.hasContenttomodel.hasContent()BREAKING CHANGE: Moved utils from
controllertomodel/utils