This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
Introduced DocumentSelection#event:change:marker #1818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fter a selection range change, like `event:change:attribute`.
Reinmar
suggested changes
Jan 29, 2020
tests/model/documentselection.js
Outdated
| @@ -442,6 +442,50 @@ describe( 'DocumentSelection', () => { | |||
|
|
|||
| expect( selection.markers.map( marker => marker.name ) ).to.have.members( [ 'marker' ] ); | |||
| } ); | |||
|
|
|||
| it( 'should fire change:marker event when selection markers change', () => { | |||
There was a problem hiding this comment.
I don't like that this is a single test. In the code I can see at least 4 or 5 scenarios. setTo, setFocus, changed not being set to true, being set to true by the first loop and by the second loop. 5 cases.
There was a problem hiding this comment.
I've split this test into multiple unit tests and added a few more. I hope you will be satisfied ;).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Feature: Introduced
DocumentSelection#event:change:marker. Closes ckeditor/ckeditor5#6133.