This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
Tests: Adjusted tests to changes in upload plugin #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f1ames
force-pushed
the
t/ckeditor5-upload/87
branch
from
9c7c2b2
to
8f2eda8
Compare
|
Sorry, I messed up by pushing some changes to this branch which should be in another one, but the PR is now back to its previous, correct state. |
jodator
suggested changes
Jan 3, 2019
There was a problem hiding this comment.
Similar request as in main PR: ckeditor/ckeditor5-upload#88 (review).
jodator
approved these changes
Jan 7, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Tests: Adjusted tests to changes in upload plugin.
Additional information
Tests adjusted to changes from https://github.com/ckeditor/ckeditor5-upload/issues/87. Should be closed after or together with ckeditor/ckeditor5-upload#88.
The CI will fail untill ckeditor/ckeditor5-upload#88 will be merged to
masterso it will be good to merge ckeditor/ckeditor5-upload#88 first and then rerun the CI job for this PR to check if it is green.