Merge pull request #149 from ckeditor/i/111

Other (generator): Removed the "experimental" label from TS and made it the default choice. Related #111.
ckeditor · Apr 25, 2023 · 5b82666 · 5b82666
2 parents f736d08 + 0dcdd24
commit 5b82666
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/packages/ckeditor5-package-generator/lib/utils/choose-programming-language.js b/packages/ckeditor5-package-generator/lib/utils/choose-programming-language.js
@@ -8,8 +8,8 @@
 const { prompt } = require( 'inquirer' );
 
 const PROGRAMMING_LANGUAGES = [
-	{ value: 'js', displayName: 'JavaScript' },
-	{ value: 'ts', displayName: 'TypeScript (experimental)' }
+	{ value: 'ts', displayName: 'TypeScript' },
+	{ value: 'js', displayName: 'JavaScript' }
 ];
 
 /**

diff --git a/packages/ckeditor5-package-generator/tests/utils/choose-programming-language.js b/packages/ckeditor5-package-generator/tests/utils/choose-programming-language.js
@@ -50,7 +50,7 @@ describe( 'lib/utils/choose-programming-language', () => {
 			name: 'programmingLanguage',
 			message: 'Choose your programming language:',
 			type: 'list',
-			choices: [ 'JavaScript', 'TypeScript (experimental)' ]
+			choices: [ 'TypeScript', 'JavaScript' ]
 		} ] );
 	} );
 
@@ -61,14 +61,14 @@ describe( 'lib/utils/choose-programming-language', () => {
 	} );
 
 	it( 'returns correct value when user picks TypeScript', async () => {
-		stubs.inquirer.prompt.resolves( { programmingLanguage: 'TypeScript (experimental)' } );
+		stubs.inquirer.prompt.resolves( { programmingLanguage: 'TypeScript' } );
 
 		const result = await chooseProgrammingLanguage( stubs.logger );
 
 		expect( result ).to.equal( 'ts' );
 	} );
 
-	it( 'returns lang option if it has valid value', async () => {
+	it( 'returns lang option if it defines a supported value', async () => {
 		const result = await chooseProgrammingLanguage( stubs.logger, 'ts' );
 
 		expect( result ).to.equal( 'ts' );
@@ -77,7 +77,7 @@ describe( 'lib/utils/choose-programming-language', () => {
 	} );
 
 	it( 'falls back to user input when lang option has invalid value', async () => {
-		stubs.inquirer.prompt.resolves( { programmingLanguage: 'TypeScript (experimental)' } );
+		stubs.inquirer.prompt.resolves( { programmingLanguage: 'TypeScript' } );
 
 		const result = await chooseProgrammingLanguage( stubs.logger, 'python' );