This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
Add catch block for failed file promise in FileRepository
#90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See also ckeditor/ckeditor5-image#264 (comment). |
|
@f1ames: Sorry for longer review - at least one test is needed for a change :) Other then that I can see we can close this and ckeditor/ckeditor5-image#264 with this one :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Other: Add catch block for failed file promise in
FileRepository.Additional information
Related to ckeditor/ckeditor5-image#264. In cases where
Fileconstructor is not supported or file promise fails for any other reason,loader.file.thenmay throw an error if there is nocatchthere (or anywhere in the code).In short, if there is no
loader.file.catchin the code (some upload adapters may have it, some not), the code before modification threw an error on rejected promise.