Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PoC of more precise consumable use in GHS and other features #10954

Closed
Reinmar opened this issue Dec 6, 2021 · 1 comment · Fixed by #11524
Closed

PoC of more precise consumable use in GHS and other features #10954

Reinmar opened this issue Dec 6, 2021 · 1 comment · Fixed by #11524
Labels
package:basic-styles package:html-support package:link squad:core Issue to be handled by the Core team. type:task This issue reports a chore (non-production change) and other types of "todos".
Milestone
iteration 53 (v34...

Comments

@Reinmar
Copy link
Member

Reinmar commented Dec 6, 2021

PoC of a solution for #10800 and related problems.

Notes from recent discussions:

  • <a href> → <a> should be consumed by LinkEditing plugin
    • This means that elementToAttribute() (upcast and two-way) will need to consume the element name if it was listed in the view: { name: ... } part.
  • <span style=x> → <span>s are a specific case – the only one where we're not interested in the element itself when some things were already consumed on it. Thus, GHS should ignore such spans on which everything was already consumed.
  • But why we have the <strong> problem too?

PoC is needed:

  • Link problem: [elementToAttribute()] consume the element name
  • Strong problem: [GHS] should check whether the element wasn't consumed already
  • Span problem: [GHS] Thus, GHS should ignore such spans on which everything was already consumed.
@Reinmar Reinmar added type:task This issue reports a chore (non-production change) and other types of "todos". package:basic-styles package:html-support package:link squad:core Issue to be handled by the Core team. labels Dec 6, 2021
@wimleers
Copy link

wimleers commented Dec 16, 2021 •
edited
Loading

PoC of a solution for #10800 and related problems.

What are the related problems? 🤓

(Asking to make sure Drupal is not affected by those.)

@lauriii lauriii mentioned this issue Mar 10, 2022
Closed
@niegowski niegowski mentioned this issue Mar 28, 2022
Merged
@CKEditorBot CKEditorBot added the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Mar 28, 2022
Reinmar added a commit that referenced this issue Apr 21, 2022
@Reinmar
Merge pull request #11524 from ckeditor/ck/10800-poc
b16a0a4 
Fix (html-support): Inline elements handled by a native editor plugin should not be handled by the GHS. Closes #10800. Closes #10954.

Fix (html-support): Unlinking should remove a link even if there were some additional attributes handled by the GHS. See #10800.

Fix (engine): The `elementToAttribute()` upcast helper should consume an element itself while consuming its attribute. See #10800.
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Apr 21, 2022
@CKEditorBot CKEditorBot added this to the iteration 53 milestone Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
package:basic-styles package:html-support package:link squad:core Issue to be handled by the Core team. type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Milestone
iteration 53 (v34.1.0)
Development

Successfully merging a pull request may close this issue.

GHS should integrate with removing a native feature attribute removing ckeditor/ckeditor5
3 participants
@wimleers @Reinmar @CKEditorBot