-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Styles dropdown] Implement the UI #11269
Comments
Problem that we encountered: How to apply These styles have lower specificity than We were thinking about:
The only feasible way for now is the second approach. |
When generating previews of styles, we need to generate their markups. However, a style for When writing CSS for these elements people will need to:
|
We have JS in Drupal for exactly this problem in a different scenario: https://git.drupalcode.org/project/drupal/-/blob/9.3.x/core/modules/ckeditor5/js/ckeditor5.es6.js#L186-L230, done in https://www.drupal.org/project/drupal/issues/3248469. We use the "donut scope" selector for this: https://css-tricks.com/weekly-platform-news-focus-rings-donut-scope-ditching-em-units-and-global-privacy-control/#aa-the-enhanced-css-not-selector-enables-donut-scope |
Feature (style): Implemented the UI of the styles dropdown. Closes #11269.
Closed in #11293. |
Why
Implementation needed for #5700.
What
Based on #11267. Implement the UI layer of the feature.
Scope:
The text was updated successfully, but these errors were encountered: