Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log error in test should not be visible #1211

Closed
pomek opened this issue Aug 21, 2018 · 2 comments
Closed

Log error in test should not be visible #1211

pomek opened this issue Aug 21, 2018 · 2 comments
Assignees
@scofalik
Labels
type:task This issue reports a chore (non-production change) and other types of "todos".
Milestone
iteration 20

Comments

@pomek
Copy link
Member

pomek commented Aug 21, 2018 •
edited
Loading

image

https://travis-ci.org/ckeditor/ckeditor5/builds/418559646

However, tests pass. But this log is ugly.
@scofalik
Copy link
Contributor

scofalik commented Aug 21, 2018 •
edited
Loading

Yes that test checks whether the error is logged but it could be silenced in some way.

@pomek
Copy link
Member Author

pomek commented Aug 21, 2018

You can stub console.error and restore it before checking assertions (expect()).

@Reinmar Reinmar added status:confirmed type:task This issue reports a chore (non-production change) and other types of "todos". labels Aug 21, 2018
@Reinmar Reinmar added this to the iteration 20 milestone Aug 21, 2018
@pomek pomek mentioned this issue Aug 24, 2018
Merged
Reinmar added a commit to ckeditor/ckeditor5-engine that referenced this issue Aug 24, 2018
@Reinmar
Merge pull request #1512 from ckeditor/t/ckeditor5/1211
7d8de56 
Tests: Error logs from transform tests should not be visible anymore. Closes ckeditor/ckeditor5#1211.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scofalik scofalik

Labels
type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Milestone
iteration 20
Development

No branches or pull requests
3 participants
@Reinmar @scofalik @pomek