Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resizer should feature explicit size input #5198

Open
mlewand opened this issue Aug 27, 2019 · 3 comments
Open

Resizer should feature explicit size input #5198

mlewand opened this issue Aug 27, 2019 · 3 comments
Labels
domain:accessibility This issue reports an accessibility problem. package:image status:discussion type:feature This issue reports a feature request (an idea for a new functionality or a missing option).

Comments

@mlewand
Copy link
Contributor

mlewand commented Aug 27, 2019

Is this a bug report or feature request?

🆕 Feature request

💻 Version of CKEditor

CKEditor v5 @ 12.4.0

📋 Steps to reproduce

This idea sparkled during ckeditor5-image#241.

The question how to do that remains open for discussion.

  • How should it be displayed?
  • Should there be a possibility to adjust height too? Should it be disconnected from width, thus allowing for breaking image aspect ratio?

There are several benefits of adding this feature:

  • Users are able to get precise image size without instead of making a super precise resize operation.
  • We make the resizer feature accessible.
  • Fields can be used to see current image size, without triggering the resizer.

References: https://github.com/ckeditor/ckeditor5-image/issues/241#issuecomment-519117147, https://github.com/ckeditor/ckeditor5-image/issues/241#issuecomment-519400868, https://github.com/ckeditor/ckeditor5-image/issues/241#issuecomment-519443993, https://github.com/ckeditor/ckeditor5-image/issues/241#issuecomment-519898056


If you'd like to see this feature implemented, add 👍 to this post.

@mlewand
Copy link
Contributor Author

mlewand commented Aug 27, 2019

For instance, one proposal was to add an input straight into the toolbar.

Another idea that we had during the image resize proposal was to make a button that would turn swap contents of image balloon toolbar, and put proper input(s) together with the reset size button (would address #5197 too).

@mlewand mlewand transferred this issue from ckeditor/ckeditor5-image Oct 9, 2019
@mlewand mlewand added this to the nice-to-have milestone Oct 9, 2019
@mlewand mlewand added domain:accessibility This issue reports an accessibility problem. status:discussion type:feature This issue reports a feature request (an idea for a new functionality or a missing option). package:image labels Oct 9, 2019
@oleq
Copy link
Member

oleq commented Jul 6, 2020

Psst! Check out #5167 (comment).

@remizorrr
Copy link

Any update on this task? any way to combine "pixels" & "%" resizing in a single interface will be helpful.

@pomek pomek removed this from the nice-to-have milestone Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:accessibility This issue reports an accessibility problem. package:image status:discussion type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Projects
None yet
Development

No branches or pull requests

4 participants