New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable missing features in CKEditor 5 builds #567

Closed
wwalc opened this Issue Sep 27, 2017 · 4 comments

Comments

Projects
None yet
2 participants
@wwalc
Copy link
Member

wwalc commented Sep 27, 2017

@Reinmar

This comment has been minimized.

Copy link
Member

Reinmar commented Sep 29, 2017

Should the "Insert image" button be available in those builds too? I know that it should not appear automatically in the toolbar, but should the plugin be enabled?

Please note that I'm asking for the future, because by a mistake, ImageUploadButton is now automatically loaded by ImageUpload plugin. This will change together with ckeditor/ckeditor5-upload#22.

@wwalc

This comment has been minimized.

Copy link
Member Author

wwalc commented Sep 29, 2017

Shouldn't we track it in a separate ticket as it's a completely separate issue?
The original issue was about two particular plugins which were already included, hence this issue could be closed.

The new issue could be about the Image Button and our strategy towards it. For example I have some concerns regarding mobiles. On mobiles the only reasonable way to insert an image is a toolbar button. If it's not available in Builds by default then there is a "?" regarding basic support for mobiles by CKEditor 5 Builds.

@Reinmar

This comment has been minimized.

Copy link
Member

Reinmar commented Sep 29, 2017

Shouldn't we track it in a separate ticket as it's a completely separate issue?

If it turns out that complicated choice then yes. Here you are: #570

Reinmar added a commit to ckeditor/ckeditor5-build-classic that referenced this issue Sep 29, 2017

Reinmar added a commit to ckeditor/ckeditor5-build-inline that referenced this issue Sep 29, 2017

Reinmar added a commit to ckeditor/ckeditor5-build-balloon that referenced this issue Sep 29, 2017

@Reinmar Reinmar closed this Sep 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment