Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy & paste of "invalid" table cell selection is broken #7245

Closed
jodator opened this issue May 20, 2020 · 0 comments · Fixed by #7451
Closed

Copy & paste of "invalid" table cell selection is broken #7245

jodator opened this issue May 20, 2020 · 0 comments · Fixed by #7451
Assignees
Labels
package:clipboard package:table type:bug This issue reports a buggy (incorrect) behavior.

Comments

@jodator
Copy link
Contributor

jodator commented May 20, 2020

This error occurs also when coping a table section that will result in broken table layout to the clipboard. I think that one fix could be addressed in two places (both when copying to the clipboard and getting table from the clipboard).

This returns only number of tableRow elements and when there are spans then this get's completely messed up eg:

+----+----+
| 00 | 01 |
+    +    +
|    |    |
+    +----+
|    | 11 |
+    +    +
|    |    |
+----+----+

for table above (such layout can be copied from bigger table) tableUtils.getRows() will return 2 but:

  • cell 00 has rowspan = 4
  • cell 01 and 11 has rowspan = 2 

I think we should use real table height.

Originally posted by @niegowski in #7226

@jodator jodator added package:clipboard package:table squad:table type:bug This issue reports a buggy (incorrect) behavior. labels May 20, 2020
@jodator jodator added this to the iteration 33 milestone Jun 4, 2020
jodator added a commit that referenced this issue Jun 18, 2020
Fix (table): Copied and pasted table fragment should maintain the proper structure when the fragment contains merged table cells. Closes #7245.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:clipboard package:table type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants