Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CloudServices plugin should destroy Token instance if provided #7248

Closed
jodator opened this issue May 20, 2020 · 1 comment · Fixed by #7257
Closed

CloudServices plugin should destroy Token instance if provided #7248

jodator opened this issue May 20, 2020 · 1 comment · Fixed by #7257
Labels
package:cloud-services type:bug This issue reports a buggy (incorrect) behavior. type:performance This issue reports a performance issue or a possible performance improvement.

Comments

@jodator
Copy link
Contributor

jodator commented May 20, 2020

📝 Provide detailed reproduction steps (if any)

When token instance is created it initiates interval callback to refresh token.

The interval must be cleared to prevent (minor) memory leak. The provided Token#destroy() is not called after the editor was destroyed.

If you'd like to see this fixed sooner, add a 👍 reaction to this post.
@jodator jodator added the type:bug This issue reports a buggy (incorrect) behavior. label May 20, 2020
@jodator
Copy link
Contributor Author

jodator commented May 20, 2020 •
edited
Loading

The fix is on the i/7248 branch but I haven't got time to write the tests yet.

@jodator jodator added package:cloud-services type:performance This issue reports a performance issue or a possible performance improvement. squad:red labels May 20, 2020
@jodator jodator mentioned this issue May 21, 2020
Merged
scofalik added a commit that referenced this issue May 21, 2020
@scofalik
Merge pull request #7257 from ckeditor/i/7248
6b60cb6 
Fix (cloud-services): Token instance will be destroyed by the CloudServices context plugin. Closes #7248.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
package:cloud-services type:bug This issue reports a buggy (incorrect) behavior. type:performance This issue reports a performance issue or a possible performance improvement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

7248: Destroy token instance if created by CloudServices plugin ckeditor/ckeditor5
1 participant
@jodator