Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DomEmitterMixin should pass "passive" option for listener #7828

Closed
niegowski opened this issue Aug 12, 2020 · 2 comments · Fixed by #7829
Closed

DomEmitterMixin should pass "passive" option for listener #7828

niegowski opened this issue Aug 12, 2020 · 2 comments · Fixed by #7829
Assignees
@niegowski
Labels
package:utils squad:magic type:improvement This issue reports a possible enhancement of an existing feature.
Milestone
iteration 35 (v22...

Comments

@niegowski
Copy link
Contributor

niegowski commented Aug 12, 2020 •
edited
Loading

📝 Provide a description of the improvement

The current implementation of DomEmitterMixin only supports useCapture option but no usePassive option.

This is needed for non-blocking scroll listeners - https://developer.mozilla.org/en-US/docs/Web/API/EventTarget/addEventListener#Improving_scrolling_performance_with_passive_listeners

If you'd like to see this improvement implemented, add a 👍 reaction to this post.
@niegowski niegowski added the type:improvement This issue reports a possible enhancement of an existing feature. label Aug 12, 2020
@niegowski niegowski self-assigned this Aug 12, 2020
@niegowski niegowski added this to the iteration 35 milestone Aug 12, 2020
@jodator
Copy link
Contributor

jodator commented Aug 12, 2020

The current implementation of DomEmitterMixin only supports useCapture option but no usePassive option.

@niegowski could you expand your ticket with why? When usePassive is needed, a use case.

@niegowski
Copy link
Contributor Author

@niegowski could you expand your ticket with why? When usePassive is needed, a use case.

This is needed for non-blocking scroll listeners - https://developer.mozilla.org/en-US/docs/Web/API/EventTarget/addEventListener#Improving_scrolling_performance_with_passive_listeners

@niegowski niegowski mentioned this issue Aug 12, 2020
Merged
oleq added a commit that referenced this issue Aug 14, 2020
@oleq
Merge pull request #7829 from ckeditor/i/201-page-editing
a7ef65c 
Feature (utils): Introduced the `passive` option support in the `DomEmitterMixin#listenTo()` method. Closes #7828.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@niegowski niegowski

Labels
package:utils squad:magic type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Milestone
iteration 35 (v22.0.0)
Development

Successfully merging a pull request may close this issue.

#7828: DomEmitterMixin should pass "passive" option for listener ckeditor/ckeditor5
2 participants
@jodator @niegowski