Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SellectAll does not select all with blockquote and table #7978

Closed
dkrahn opened this issue Aug 31, 2020 · 1 comment · Fixed by #8518
Closed

SellectAll does not select all with blockquote and table #7978

dkrahn opened this issue Aug 31, 2020 · 1 comment · Fixed by #8518
Assignees
Labels
squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior.

Comments

@dkrahn
Copy link
Contributor

dkrahn commented Aug 31, 2020

📝 Provide detailed reproduction steps (if any)

  1. Open https://ckeditor.com/docs/ckeditor5/latest/examples/builds/document-editor.html
  2. In the console run editor.setData('<blockquote><p>blockquote</p><figure class="table"><table><tbody><tr><td>Table</td></tr></tbody></table></figure></blockquote>')
  3. Select all with Ctrl + A

✔️ Expected result

Expected to select all content in the editor.

❌ Actual result

Only selects first part os the text outside the table.

📃 Other details

If first and last elements of the editor are tables, it doesn't sellect all elements.

  • Browser: Chrome
  • OS: Windows
  • CKEditor version: 22.0.0
  • Installed CKEditor plugins: [Clipboard, Enter, SelectAllEditing, SelectAllUI, SelectAll, ShiftEnter, Input, Delete, Typing, UndoEditing, Undo, Essentials, AlignmentEditing, AlignmentUI, Alignment, FontSizeEditing, FontSize, FontFamilyEditing, FontFamily, FontColorEditing, FontColorUI, FontColor, FontBackgroundColorEditing, FontBackgroundColorUI, FontBackgroundColor, PendingActions, FileRepository, CKFinderUploadAdapter, Autoformat, BoldEditing, Bold, ItalicEditing, Italic, StrikethroughEditing, Strikethrough, UnderlineEditing, Underline, BlockQuoteEditing, BlockQuote, Notification, ImageEditing, TwoStepCaretMovement, LinkEditing, CKFinderEditing, CKFinderUI, CKFinder, CloudServices, WidgetTypeAround, Widget, ImageTextAlternativeEditing, ContextualBalloon, ImageTextAlternativeUI, ImageTextAlternative, Image, ImageUploadEditing, ImageUploadUI, ImageUpload, EasyImage, Paragraph, HeadingEditing, Heading, ImageCaptionEditing, ImageCaption, ImageStyleEditing, ImageStyleUI, ImageStyle, WidgetToolbarRepository, ImageToolbar, IndentEditing, IndentUI, Indent, IndentBlock, LinkUI, Link, ListEditing, List, MediaEmbedEditing, MediaEmbedUI, AutoMediaEmbed, MediaEmbed, PasteFromOffice, TableUtils, TableEditing, TableSelection, TableMouse, TableKeyboard, TableClipboard, Table, TableToolbar, TextTransformation]

If you'd like to see this fixed sooner, add a 👍 reaction to this post.

@dkrahn dkrahn added the type:bug This issue reports a buggy (incorrect) behavior. label Aug 31, 2020
@FilipTokarski
Copy link
Member

FilipTokarski commented Aug 31, 2020

Hi, thanks for the report. I confirm this bug. What is worse here, if after Ctrl+A you press Backspace, editor crashes:

Uncaught TypeError: Cannot read property 'isCollapsed' of undefined
    at cn.hasContent (snippet.js:4)
    at snippet.js:4
    at snippet.js:4
    at cn.change (snippet.js:4)
    at Ke (snippet.js:4)
    at cn.deleteContent (snippet.js:4)
    at cn.<anonymous> (snippet.js:4)
    at cn.fire (snippet.js:4)
    at cn.<computed> [as deleteContent] (snippet.js:4)
    at Object.callback (snippet.js:4)

More info:

  • crashes also with images and media embeds
  • widget needs to be the last item inside the BlockQuote
  • Chrome and Safari crash since 19.0.0 ( on previous versions selection is ok but Backspace does nothing )
  • Firefox crashes even on 15.0.0

@Reinmar Reinmar added the squad:core Issue to be handled by the Core team. label Oct 8, 2020
@Reinmar Reinmar added this to the nice-to-have milestone Oct 8, 2020
@niegowski niegowski self-assigned this Nov 24, 2020
@niegowski niegowski modified the milestones: nice-to-have, iteration 38 Nov 24, 2020
jodator added a commit that referenced this issue Nov 24, 2020
Fix (engine): The select all command should include all selectable elements in the content. Closes #7978.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
4 participants