Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The grouped items toolbar button tooltip should not cause horizontal scroll on the web page #8655

Closed
oleq opened this issue Dec 14, 2020 · 0 comments · Fixed by #8672
Closed

The grouped items toolbar button tooltip should not cause horizontal scroll on the web page #8655

oleq opened this issue Dec 14, 2020 · 0 comments · Fixed by #8672
Assignees
@magda-chrzescian
Labels
domain:ui/ux This issue reports a problem related to UI or UX. intro Good first ticket. package:ui type:improvement This issue reports a possible enhancement of an existing feature.
Milestone
iteration 39 (v25...

Comments

@oleq
Copy link
Member

oleq commented Dec 14, 2020

📝 Provide a description of the improvement

Since iteration38, there are 2 new TooltipView#positions (south-west and south-east) and if used properly in the right place depending on the UI language direction they will make this

look like this

as in https://github.com/ckeditor/ckeditor5/issues/7327#issuecomment-636839122. 

📃 Other details

This will resolve 50% of #7327.

If you'd like to see this improvement implemented, add a 👍 reaction to this post.
@oleq oleq added type:improvement This issue reports a possible enhancement of an existing feature. intro Good first ticket. package:ui domain:ui/ux This issue reports a problem related to UI or UX. labels Dec 14, 2020
@oleq oleq added this to the nice-to-have milestone Dec 14, 2020
@oleq oleq mentioned this issue Dec 14, 2020
Closed
@oleq oleq modified the milestones: nice-to-have, iteration 39 Dec 14, 2020
@magda-chrzescian magda-chrzescian mentioned this issue Dec 15, 2020
Merged
oleq added a commit that referenced this issue Dec 22, 2020
@oleq
Merge pull request #8672 from ckeditor/i/8655-grouped-toolbar-tooltip
6175a20 
Fix (ui): The "Show more items" toolbar button tooltip should not overflow the editor. Closes #8655.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@magda-chrzescian magda-chrzescian

Labels
domain:ui/ux This issue reports a problem related to UI or UX. intro Good first ticket. package:ui type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Milestone
iteration 39 (v25.0.0)
Development

Successfully merging a pull request may close this issue.

Custom tooltip position for grouped items in toolbar. ckeditor/ckeditor5
2 participants
@oleq @magda-chrzescian