Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#6819: Added Writer#cloneElement() #7373

Merged
merged 3 commits into from
Jun 4, 2020
Merged

#6819: Added Writer#cloneElement() #7373

merged 3 commits into from
Jun 4, 2020

Conversation

niegowski
Copy link
Contributor

Suggested merge commit message (convention)

Other (engine): Added Writer#cloneElement(). Closes #6819.

Internal (table): Replaced Element._clone() usages with Writer#cloneElement().

Additional information

@niegowski niegowski requested a review from jodator June 3, 2020 18:30
jodator
jodator approved these changes Jun 4, 2020
View reviewed changes
Copy link
Contributor

@jodator jodator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jodator jodator merged commit 4c71140 into master Jun 4, 2020
@jodator jodator deleted the i/6819 branch June 4, 2020 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jodator jodator jodator approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Introduce method to easily "clone" element with children to model writer.
2 participants
@niegowski @jodator