Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide selection handle in nested widget, if outer widget is hovered or selected #9457

Merged
merged 2 commits into from
Apr 13, 2021

Conversation

psmyrek
Copy link
Contributor

@psmyrek psmyrek commented Apr 13, 2021

Suggested merge commit message (convention)

Fix (widget): Hide selection handle in nested widget, if outer widget is hovered or selected. Closes #9453.


Additional information

I wasn't sure, if this change should only apply to nested tables, or be global. I chose the latter option and now all nested widgets will look the same.

9453.mp4

@niegowski
Copy link
Contributor

There is also the gray one for blurred editor:

@psmyrek
Copy link
Contributor Author

psmyrek commented Apr 13, 2021

Now it should be better - color for nested selection handle is the same as its outline.

9453.mp4

@oleq
Copy link
Member

oleq commented Apr 13, 2021

LGTM. Nice that you managed to create a test for it 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The widget selection handle on nested table is affected by the outer table widget
3 participants