Updated focus behavior for heading and code. #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into ghw/380-heading-code-focus-not-moving
mlewand
suggested changes
Oct 21, 2022
src/app/plugins/headingdropdown.js
Outdated
| @@ -84,6 +86,14 @@ export default class HeadingDropdown extends Plugin { | |||
| ] ); | |||
| dropdown.toolbarView.fillFromConfig( toolbarConfig.items, editor.ui.componentFactory ); | |||
|
|
|||
| dropdown.on( 'change:isOpen', ( evt, name, isOpen ) => { | |||
There was a problem hiding this comment.
I miss a reference comment to the origin issue.
There was a problem hiding this comment.
But why do you focus the editable upon closing heading dropdown? This behavior would be inconsistent with other features (and a little disruptive quite frankly).
mlewand
approved these changes
Oct 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Focus and selection will now remain on the text when the Heading or Code buttons are pressed. Closes #380.