Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility Checker losses some functionallity after making a quickfix #41

Closed
mlewand opened this issue Oct 23, 2014 · 1 comment
Closed
Assignees
Labels
Milestone

Comments

@mlewand
Copy link
Contributor

mlewand commented Oct 23, 2014

This is a regression, most likely introduced in a05804a (#38).

After performing a quick fix, the Accessibility Icon in toolbar is disabled. Therefore I assume Controller.enabled is changed.

  1. Open any sample with Accessibility Checker. (i.e. plugins/a11ychecker/dev/sample.html)
  2. Navigate to the first issue which supports quick fixes.
  3. Apply quick fix.

Expected result:
Checker should remain in checking mode. Toolbar icon should indicate that Accessibility Checker is on.

Current result:
The icon goes off, as if Accessibilty Checker would be disabled.

Additional info:

  1. I guess it might be a good idea to see if it's possible not to close balloon each time we change focused issue, but only update its contents.
@mlewand mlewand added the bug label Oct 23, 2014
@mlewand mlewand self-assigned this Oct 23, 2014
@mlewand mlewand added this to the 0.0.4 milestone Oct 23, 2014
@mlewand
Copy link
Contributor Author

mlewand commented Oct 23, 2014

Alright, so the reason for that problem was that when we were moving to the other issue the balloon was hidden and shown once again.

When it was hidden, the element which had a focus was firing a blur event, which in turn (with some timeout) caused the editor#blur event.

In result, according to changes in #38 it was closing the Accessibility Checker too soon.

I decided to put focus back to the editor while hiding a balloon, that makes sense, since always we want to go back to editing.

@mlewand mlewand changed the title Accessibility Checker becomes losses some functionallity after making a quickfix Accessibility Checker losses some functionallity after making a quickfix Oct 29, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant