Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'erode_labels' is missing an argument relabel_islands #141

Closed
haesleinhuepf opened this issue Feb 14, 2024 · 2 comments · Fixed by #173
Closed

'erode_labels' is missing an argument relabel_islands #141

haesleinhuepf opened this issue Feb 14, 2024 · 2 comments · Fixed by #173
Labels
prototype issues raised from removing the prototype wontfix This will not be worked on

Comments

@haesleinhuepf
Copy link
Member

Compared to the prototype-version, the function erode_labels has missing an argument relabel_islands.

Notebook to try it out:
https://haesleinhuepf.github.io/BioImageAnalysisNotebooks/20h_segmentation_post_processing/open_close_labels.html
@haesleinhuepf haesleinhuepf changed the title 'erode_labels' as missing an argument relabel_islands 'erode_labels' is missing an argument relabel_islands Feb 14, 2024
@StRigaud
Copy link
Member

relabel_island parameter was renamed relabel.

The reason is that the operation behind is a simple sequantial relabeling, the island par is therefore miss leading.
We can put it back as it was if it make more sense

@StRigaud StRigaud added wontfix This will not be worked on prototype issues raised from removing the prototype labels Feb 14, 2024
@haesleinhuepf
Copy link
Member Author

ok, awesome, that makes sense!

StRigaud added a commit that referenced this issue Apr 4, 2024
@StRigaud
fix 'erode_labels' is missing an argument relabel_islands #141
0e8d8d0
@StRigaud StRigaud linked a pull request Apr 4, 2024 that will close this issue
Prototype-migration-documentation #173
Merged
This was referenced May 14, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
prototype issues raised from removing the prototype wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prototype-migration-documentation clEsperanto/pyclesperanto
2 participants
@StRigaud @haesleinhuepf