Transform enhancement squashed rebased #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -360,6 +360,40 @@ clsparseDCsrMatrixfromFile( clsparseCsrMatrix* csrMatx, const char* filePath, cl | |||
| const cldenseVector* y, | |||
| const clsparseControl control ); | |||
|
|
|||
| // functions for tests of scan transformation, as simple as possible | |||
|
I have not benchmarked your refactoring of coo2csr, csr2coo, dense2csr, csr2dense, but a phenomenal job simplifying the code and eliminating kernel passes! |
|
@jpola |
1. Added more information to message when failed to read matrix from file. 2. Reorganized functions related to computing rowBlocks they are now in csr-meta.hpp / cpp files instead of clsparse-coo2csr.cpp, rest of functions in clsparse-coo2csr were not used therfore name clsparse-coo2csr-GPU changed to proper one. 3. Csr_matrix_environment allocates matrix in double precision in the first place which is then casted to single precision. 4. Sanity checks in clsparseD/SCsrMatrixFromFile. 5. Added Inclusive and exclusive scans operations + tests. 6. Rewritten reduce by key operation + tests. 7. Rewriten coo2csr and csr2coo which no longer need the use of radix sort. I.e we now using 10 kernel calls instead of 34, simple tests showed 6x speedup. 8. Rewritten dense2csr and csr2dense in more clean way. Improved performance eliminating unnecessary copies. Minor: 1. When reading matix in coo format directly the data need to be also sorted by (row, col). Otherwise we will have column major format which is default for mtx storage.
…duce by key functions and corresponding tests
|
Hi, sorry for delay. 2015-09-01 6:32 GMT+02:00 Kent Knox notifications@github.com:
|
kknox
pushed a commit
that referenced
this pull request
Sep 1, 2015
Transform enhancement squashed rebased 👍
This was referenced Sep 1, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.