Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing to specify patterns for ignored repos during org linking #162

Merged

Conversation

dennisoelkers
Copy link
Contributor

This change adds a field "excludePattern" to the org model, which allows to specify a comma-separated list of repository names or substrings which are matched against the repository of an incoming or rechecked PR. If the string matches against the repo name, the PR is ignored and no
CLA check is done.

Fixes #157.

This change adds a field "excludePattern" to the org model, which allows
to specify a comma-separated list of repository names or substrings
which are matched against the repository of an incoming or rechecked PR.
If the string matches against the repo name, the PR is ignored and no
CLA check is done.
@CLAassistant
Copy link
Member

CLAassistant commented Sep 26, 2016

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.4%) to 91.271% when pulling a965e13 on Graylog2:exclude-patterns-for-org-linking into e51b6fe on cla-assistant:master.

@KharitonOff
Copy link
Contributor

Great job! 👍 Thank you for your contribution! 😄 It works good so far.
We appreciate it very much.

The only point I have: there is no way to find out which repos/pattern I've excluded after the org is linked. I could imagine to have this info as a popover placed on the org name or even better as a modal view, where the user can edit this entry.

@dennisoelkers
Copy link
Contributor Author

Thanks for your quick review and feedback, I appreciate it very much! I am right now to add some test coverage for the isRepoExcluded function, so coveralls is happy again. After that I will add a popover to the organization list, that's a good idea!

I actually had in mind to add a function to the organization action menu which allows you to edit the pattern string, but that's a bit more work than the part which allows you to specify one during linking.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) to 91.713% when pulling e9af3d1 on Graylog2:exclude-patterns-for-org-linking into e51b6fe on cla-assistant:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) to 91.713% when pulling fbca91b on Graylog2:exclude-patterns-for-org-linking into e51b6fe on cla-assistant:master.

@dennisoelkers
Copy link
Contributor Author

Is there a chance to get this merged and deployed to cla-assistant.io? We would have to set up our own instance otherwise.

@KharitonOff
Copy link
Contributor

Sure. This week or next week I'm going to take some time for review. After that we can take over your changes into CLA assistant

@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) to 91.713% when pulling 3ef8c3d on Graylog2:exclude-patterns-for-org-linking into e51b6fe on cla-assistant:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) to 91.713% when pulling 23508bc on Graylog2:exclude-patterns-for-org-linking into e51b6fe on cla-assistant:master.

@KharitonOff
Copy link
Contributor

Great job! Thank you for your contribution 👍
It looks good for me.
I did some minor changes on the UI: place the tooltip only on the org name and adjusted it's text for the orgs without exclude pattern. I hope you are ok with it.

@KharitonOff KharitonOff merged commit 60c4302 into cla-assistant:master Sep 30, 2016
@fr34kyn01535
Copy link

I would love to be able to edit the pattern once i linked a organization

@KharitonOff
Copy link
Contributor

@fr34kyn01535 this feature is not implemented yet, but you are very welcome to make a contribution to this project 😏 See issue #182

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants