-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allowing to specify patterns for ignored repos during org linking #162
Allowing to specify patterns for ignored repos during org linking #162
Conversation
This change adds a field "excludePattern" to the org model, which allows to specify a comma-separated list of repository names or substrings which are matched against the repository of an incoming or rechecked PR. If the string matches against the repo name, the PR is ignored and no CLA check is done.
Great job! 👍 Thank you for your contribution! 😄 It works good so far. The only point I have: there is no way to find out which repos/pattern I've excluded after the org is linked. I could imagine to have this info as a popover placed on the org name or even better as a modal view, where the user can edit this entry. |
Thanks for your quick review and feedback, I appreciate it very much! I am right now to add some test coverage for the I actually had in mind to add a function to the organization action menu which allows you to edit the pattern string, but that's a bit more work than the part which allows you to specify one during linking. |
Is there a chance to get this merged and deployed to cla-assistant.io? We would have to set up our own instance otherwise. |
Sure. This week or next week I'm going to take some time for review. After that we can take over your changes into CLA assistant |
Great job! Thank you for your contribution 👍 |
I would love to be able to edit the pattern once i linked a organization |
@fr34kyn01535 this feature is not implemented yet, but you are very welcome to make a contribution to this project 😏 See issue #182 |
This change adds a field "excludePattern" to the org model, which allows to specify a comma-separated list of repository names or substrings which are matched against the repository of an incoming or rechecked PR. If the string matches against the repo name, the PR is ignored and no
CLA check is done.
Fixes #157.