Fix compiling on M1 Macs #1648
Merged
Fix compiling on M1 Macs #1648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This flag causes issues on M1 Macs, as clang does not support this flag on this platform. Instead, use -march-apple-m1.
|
Thank you! |
|
@neubig thanks for the package support. Is there any update on making dynet available on arm-based Mac? Thanks. |
|
@JonArcherII could you elaborate on your answer. thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clang on M1 does not support
-march=native, so instead let's explicitly use-mcpu=apple-m1, this was all that was needed to have a mac python build.Fixes #1644.