Initial attempt to add virtio-rng to install VM #260
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Work fine with my testing |
|
@imcleod This looks OK to me with a slight tweak. My biggest question with it has to do with aarch64 and s390x. Do we need to do something different/conditional for those? |
|
@clalancette - I'm not entirely sure. In my limited experience, the virtio devices are cross-architecture. I guess I'm in a better position to test, thanks to some indirect hardware access. Let me get back to you. |
|
Works fine with aarch64 at least. I don't believe we've seen issues with s390x (or at least it's ignored) |
|
Great, thanks for the testing and the advice. I've now applied this with some small fixups. Thanks for the patch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
F29/rawhide composes are hitting an issue where the kernel is now timing out at boot, waiting for sufficient entropy. The hope is that allowing entropy pass-through from the host will correct this. I'm opening this PR as a starting point. This feature seems to have been added to libvirt quite a while ago (2012).
Reference for failed rawhide image builds: https://bugzilla.redhat.com/show_bug.cgi?id=1572916
Tested briefly on my F27 laptop installing an F27 guest. I could see that the virtio-rng module loaded in the install guest which I believe is what we want to occur.