New internal implementation of data lists (Mmif.media, Mmif.views, View.annotations) #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angus-lherrou
changed the title
|
Creating this draft PR to resolve conflicts with develop and discuss code changes |
This was referenced Aug 3, 2020
angus-lherrou
force-pushed
the
40-dicts-keyed-by-id
branch
from
f655440
to
805ab83
Compare
|
Rebased off of new develop branch |
Codecov Report
@@ Coverage Diff @@
## develop #60 +/- ##
===========================================
- Coverage 96.56% 96.04% -0.52%
===========================================
Files 7 7
Lines 349 430 +81
===========================================
+ Hits 337 413 +76
- Misses 12 17 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
angus-lherrou
added a commit
that referenced
this pull request
Aug 6, 2020
Adding some tests written during work on #60
…in the live objects
…e internal data structure away from the Mmif method logic
…el.py to avoid circular import
…eserialize super method
angus-lherrou
force-pushed
the
40-dicts-keyed-by-id
branch
from
28235c1
to
14cbdbc
Compare
|
Rebased again |
angus-lherrou
changed the title
|
Fixed merge conflicts |
keighrim
reviewed
Aug 13, 2020
…tion in DataList._append_with_key. Ensures unique insertion.
keighrim
force-pushed
the
40-dicts-keyed-by-id
branch
from
26347bf
to
38ab0ca
Compare
keighrim
approved these changes
Aug 13, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have implemented
__getitem__for Mmif and View and implemented the Mmif.media, Mmif.views, and View.annotations lists internally as MmifObject::DataList objects that hide the implementation of these lists.For now, I have implemented DataLists as dicts that serialize into lists. We can continue discussing the pros and cons of using dicts vs lists here or in #40.