Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix inlay-hint not shown issue #341

Merged
merged 4 commits into from
Jul 11, 2022
Merged

Fix inlay-hint not shown issue #341

merged 4 commits into from
Jul 11, 2022

Conversation

hokein
Copy link
Collaborator

@hokein hokein commented May 30, 2022 •
edited
Loading

when using a standard-inlay-hint-supported clangd

@hokein
Fix inlay-hint not shown issue when using a standard-inlay-hint-suppo…
fa6ed67 
…rted clangd

- Fixes #1164;
- Also fixes the `clangd.inlayHints.toggle command not found` issue;
@hokein hokein changed the title Fix inlay-hint not shown issue [WIP] Fix inlay-hint not shown issue May 30, 2022
@hokein
Copy link
Collaborator Author

hokein commented May 30, 2022

oh, wait, CI is failing -- vscodelanguage-client 8.0 has a breaking API change, looking at it...

@hokein
Fix the build failures caused by vscode-languageclient API changes;
5e61f54
@hokein
Update the Typescipt dependency.
0ba1b7a 
Get rid of the "An index signature parameter type cannot be a type alias" errors on
vscode-languageserver-protocol/lib/common files
@hokein hokein changed the title [WIP] Fix inlay-hint not shown issue Fix inlay-hint not shown issue May 30, 2022
@hokein
Copy link
Collaborator Author

hokein commented May 30, 2022

should be good to go.

@HighCommander4 HighCommander4 mentioned this pull request Jun 21, 2022
Open
kadircet
kadircet approved these changes Jul 8, 2022
View reviewed changes
Copy link
Member

@kadircet kadircet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, lgtm apart form the command registry condition

src/inlay-hints.ts Show resolved Hide resolved
@lh123 lh123 mentioned this pull request Jul 11, 2022
Open
@hokein hokein merged commit eb61c51 into master Jul 11, 2022
@hokein hokein deleted the fix-inlay-hints branch July 11, 2022 11:36
sam-mccall added a commit that referenced this pull request Jul 11, 2022
@sam-mccall
Revert "Fix inlay-hint not shown issue (#341)"
fc750f1 
This reverts commit eb61c51.

Unfortunately the languageclient upgrade causes completion problems e.g.
#357

Need to work out how to address these before rolling forward.
sam-mccall added a commit that referenced this pull request Jul 12, 2022
@sam-mccall
Revert "Revert "Fix inlay-hint not shown issue (#341)""
a562edc 
This reverts commit fc750f1.

It's now (presumed) safe to bump languageclient to 8.x after suppressing
commit characters.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kadircet kadircet kadircet approved these changes

@sam-mccall sam-mccall Awaiting requested review from sam-mccall

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

inlay hints gone
2 participants
@hokein @kadircet