Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added handling of predefined variable ${userHome} #486

Merged
merged 3 commits into from
May 26, 2023
Merged

Added handling of predefined variable ${userHome} #486

merged 3 commits into from
May 26, 2023

Conversation

Singha360
Copy link
Contributor

@Singha360 Singha360 commented May 25, 2023 •
edited

Resolves #485
Noticed my silly mistake

@HighCommander4
Copy link
Contributor

Thanks! Can you clang-format the patch so it passes the CI check please?

@HighCommander4
Copy link
Contributor

@hokein added you as a reviewer, just to make sure you're fine with the general approach of supporting new variables on a case by case basis here

hokein
hokein approved these changes May 26, 2023
View reviewed changes
Copy link
Collaborator

@hokein hokein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good to me.

@HighCommander4 HighCommander4 merged commit d0653e6 into clangd:master May 26, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hokein hokein hokein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

clangd extensions should respect vscode settings variables standards
3 participants
@Singha360 @HighCommander4 @hokein