-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Visual bugs in cmd
with stray underlines
#4431
Comments
Tbat most likely means something is going wrong with termcolor's wincon support as that is most likely the main difference between the two terminals. Whats especially weird is that there is no reason to put an underline after "information" as we only use underline in headers and so we aren't touching it at that point. If you want to go an extra step, reproducing this in termcolor and creating an upstream issue would be great. With #1433, we will most likely be moving off of termcolor though, so we'll need to keep in mind to fix this when we do. |
I'm seeing this happen in Wezterm, but specifically only when the help text is printed when the output in the terminal window has reached the bottom. It happens under that condition with both |
Windows will style all blank space until the end of line (sometimes). Fixes clap-rs#4431
Windows will style all blank space until the end of line (sometimes). Fixes clap-rs#4431
Windows will style all blank space until the end of line (sometimes). Fixes clap-rs#4431
Please complete the following tasks
Rust Version
rustc 1.65.0-nightly (f03ce3096 2022-08-08)
Clap Version
4.0.18
Minimal reproducible code
Steps to reproduce the bug with the above code
cargo run -- --help
Actual Behaviour
Expected Behaviour
Additional Context
The first screenshot shows cmd, the second screenshot shows windows terminal. I wasn't able to trigger this bug in windows terminal but it's worth noting that even in cmd, it doesn't always happen:
Debug Output
No response
The text was updated successfully, but these errors were encountered: