Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

completion does not respect global arguments #841

Closed
laishulu opened this issue Feb 3, 2017 · 3 comments
Closed

completion does not respect global arguments #841

laishulu opened this issue Feb 3, 2017 · 3 comments
Labels
A-completion Area: completion generator C-bug Category: Updating dependencies
Milestone

Comments

@laishulu
Copy link

laishulu commented Feb 3, 2017

Rust Version

rustc -V

Affected Version of clap

clap 2.20.0

Expected Behavior Summary

  1. global-arg is a global arg of myapp which can be used in subcmd, i.e both myapp --global-arg subcmd and myapp subcmd --global-arg work
  2. when I type myapp subcmd --[tab], global-arg should pops up.

Actual Behavior Summary

when I type myapp subcmd --[tab], global-arg does not show up

@kbknapp
Copy link
Member

kbknapp commented Feb 3, 2017

Three questions for you:

@laishulu
Copy link
Author

laishulu commented Feb 3, 2017

                    app.gen_completions_to("myapp",
                                           Shell::Zsh,
                                           &mut io::stdout())

I use zsh. underscore is in nowhere.

@kbknapp kbknapp added A-completion Area: completion generator D: easy C-bug Category: Updating dependencies and removed T: RFC / question labels Feb 3, 2017
@kbknapp kbknapp added this to the 2.20.3 milestone Feb 3, 2017
@kbknapp
Copy link
Member

kbknapp commented Feb 3, 2017

Alright, I have this fixed, once #842 merges I'll start the new PR

kbknapp added a commit that referenced this issue Feb 3, 2017
kbknapp added a commit that referenced this issue Feb 3, 2017
kbknapp added a commit that referenced this issue Feb 3, 2017
kbknapp added a commit that referenced this issue Feb 3, 2017
kbknapp added a commit that referenced this issue Feb 3, 2017
kbknapp added a commit that referenced this issue Feb 3, 2017
@kbknapp kbknapp closed this as completed in 92919f5 Feb 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-completion Area: completion generator C-bug Category: Updating dependencies
Projects
None yet
Development

No branches or pull requests

2 participants