Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable typo suggestions in presence of external subcommands #1215

Merged
merged 1 commit into from
Mar 19, 2018

Conversation

matklad
Copy link
Contributor

@matklad matklad commented Mar 19, 2018

Fix for rust-lang/cargo#5201 =P


This change is Reviewable

@kbknapp
Copy link
Member

kbknapp commented Mar 19, 2018

Awesome, thanks! 👍

@kbknapp kbknapp merged commit 32f3c18 into clap-rs:master Mar 19, 2018
@matklad
Copy link
Contributor Author

matklad commented Mar 19, 2018

@kbknapp would it be possible to make a release then? I’d love to update clap at rust-lang/rust and fix the nightlies:)

@kbknapp kbknapp mentioned this pull request Mar 19, 2018
87 tasks
@kbknapp
Copy link
Member

kbknapp commented Mar 19, 2018

v2.31.2 is out 😉

@matklad matklad deleted the subcommand-isnt-a-typo branch March 20, 2018 07:52
bors added a commit to rust-lang/rust that referenced this pull request Mar 20, 2018
Update clap

This should fix a regression in Cargo after swithing to clap, when
an external subcommand was not discovered, if its name was close to
a built in command.

bug report: #48986 (comment)
fix: clap-rs/clap#1215
bors added a commit to rust-lang/rust that referenced this pull request Mar 20, 2018
Update clap

This should fix a regression in Cargo after swithing to clap, when
an external subcommand was not discovered, if its name was close to
a built in command.

bug report: #48986 (comment)
fix: clap-rs/clap#1215
kennytm added a commit to kennytm/rust that referenced this pull request Mar 20, 2018
Update clap

This should fix a regression in Cargo after swithing to clap, when
an external subcommand was not discovered, if its name was close to
a built in command.

bug report: rust-lang#48986 (comment)
fix: clap-rs/clap#1215
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants