Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of #[clap(no_version)] #1676

Merged
merged 1 commit into from
Feb 5, 2020
Merged

Get rid of #[clap(no_version)] #1676

merged 1 commit into from
Feb 5, 2020

Conversation

CreepySkeleton
Copy link
Contributor

Do what I wanted to do for a long time - get rid of no_version and replace it with "no version by default, use version to do it explicitly".

@CreepySkeleton
Copy link
Contributor Author

Argh! I guess I need a pre-commit hook with cargo-fmt.

pksunkara
pksunkara requested changes Feb 5, 2020
View reviewed changes
Copy link
Member

@pksunkara pksunkara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor but important changes

clap_derive/examples/README.md Show resolved Hide resolved
clap_derive/examples/README.md Outdated Show resolved Hide resolved
pksunkara
pksunkara approved these changes Feb 5, 2020
View reviewed changes
Copy link
Member

@pksunkara pksunkara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@bors
Copy link
Contributor

bors bot commented Feb 5, 2020

🕐 Waiting for PR status (Github check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set.

@CreepySkeleton
Copy link
Contributor Author

bors r=pksunkara

bors bot added a commit that referenced this pull request Feb 5, 2020
@bors @CreepySkeleton
Merge #1676
f0929d3 
1676: Get rid of `#[clap(no_version)]` r=pksunkara a=CreepySkeleton

Do what I wanted to do for a long time - get rid of `no_version` and replace it with "no version by default, use `version` to do it explicitly".

Co-authored-by: CreepySkeleton <creepy-skeleton@yandex.ru>
@CreepySkeleton
Copy link
Contributor Author

Nope, bors doesn't build if it was called for too early, before all the checks passed. @pksunkara any ideas?

@pksunkara
Copy link
Member

It should. I had added the prerun_timeout_sec option. I want to look into bors for sure later

@Dylan-DPC-zz
Copy link

No. It's better it works that way. Better to call r+ only after everything passes.

@CreepySkeleton
Copy link
Contributor Author

@Dylan-DPC r+ Lets' imagine that I've reviewed a PR, I approved it, but checks have not passed yet. I'd like to be able to tell bors "I approve, but let's wait for checks to pass", and r+ should mean exactly that.

(bors itself tells you that)

Bors will automatically try to run when all required PR statuses are set.

It should work that way, but I guess it doesn't.

@pksunkara
Copy link
Member

And if checks fail bots wouldn't build it anyway

@bors
Copy link
Contributor

bors bot commented Feb 5, 2020

Build succeeded

@bors bors bot merged commit 8221c4f into master Feb 5, 2020
@bors bors bot deleted the ditch-no-version branch February 5, 2020 15:08
@CreepySkeleton
Copy link
Contributor Author

By the way, is there a way to make bors use fast-forward merge if there's only one commit?

@CreepySkeleton
Copy link
Contributor Author

Ability to squash would be nice too.

@epage epage mentioned this pull request Nov 18, 2021
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TeXitoi TeXitoi TeXitoi approved these changes

@pksunkara pksunkara pksunkara approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CreepySkeleton @pksunkara @Dylan-DPC-zz @TeXitoi