Remove {n} support #1810
Merged
Remove {n} support #1810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build succeeded |
|
@pksunkara what was the motivation for this change? Solving a similar problem came up in #3198 and wanting to learn from the past on this. |
|
It was deprecated in v2.11 and was planned to be removed in v3. |
epage
added a commit
to epage/clap
that referenced
this pull request
Dec 30, 2021
This reverts commit 333b993. PR clap-rs#1810's motivation was effectively "this is redundant with `\n`". That is a fine motivation. Unfortunately, we don't have a way to force a hard break in `clap_derive`. clap-rs#2389 should help with this eventually but we shouldn't hold up 3.0 to get that ready. So in the mean time, we are restoring `{n}`. We have clap-rs#3230 for tracking the re-removal of it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.