Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add coveralls #218

Merged
merged 2 commits into from
Sep 3, 2015
Merged

Add coveralls #218

merged 2 commits into from
Sep 3, 2015

Conversation

Vinatorul
Copy link
Contributor

Do not merge

@Vinatorul
Copy link
Contributor Author

It works, but without yaml example
60% coverage: https://coveralls.io/github/kbknapp/clap-rs

@Vinatorul
Copy link
Contributor Author

So it works and works well. The problem is in yaml feature


use clap::App;

fn main() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to delete this example file?

@kbknapp
Copy link
Member

kbknapp commented Sep 2, 2015

Nice! This is something I've been wanting to add, but just haven't been too familiar with.

@Vinatorul
Copy link
Contributor Author

Now I am just experimenting. When it will be ready - I will do a single commit :)

@Vinatorul
Copy link
Contributor Author

Well, now it doesn't build examples and tests at all =(

@kbknapp
Copy link
Member

kbknapp commented Sep 2, 2015

Haha ok 😄

@Vinatorul Vinatorul force-pushed the coveralls branch 2 times, most recently from 0745e91 to a6e0e4b Compare September 2, 2015 22:30
@Vinatorul
Copy link
Contributor Author

Script to avoid travis-cargo:

sudo apt-get install libcurl4-openssl-dev libelf-dev libdw-dev &&
  wget https://github.com/SimonKagstrom/kcov/archive/master.tar.gz &&
  tar xzf master.tar.gz && mkdir kcov-master/build && cd kcov-master/build && cmake .. && make &&
  sudo make install && cd ../.. &&
  kcov --coveralls-id=$TRAVIS_JOB_ID --exclude-pattern=/.cargo target/kcov target/debug/clap-*

Maybe you will see what to change here to fix it (now in checks only clap tests)

@Vinatorul
Copy link
Contributor Author

Ready to merge

@Vinatorul
Copy link
Contributor Author

I've set threshold to 60% for now, when coverage will reach 80% - we'll set it to 80% I think.
Decrease threshold is 5% now

@kbknapp
Copy link
Member

kbknapp commented Sep 3, 2015

👍 excellent work!

@Vinatorul
Copy link
Contributor Author

Excellent work will be when we hit 80% coverage. There is a lot of work now. And I'll start to implement some. The main problem is with false negative tests =(

Vinatorul added a commit that referenced this pull request Sep 3, 2015
@Vinatorul Vinatorul merged commit 9b6e3c0 into clap-rs:master Sep 3, 2015
@Vinatorul Vinatorul deleted the coveralls branch September 3, 2015 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants