-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add coveralls #218
Add coveralls #218
Conversation
It works, but without yaml example |
So it works and works well. The problem is in yaml feature |
|
||
use clap::App; | ||
|
||
fn main() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you mean to delete this example file?
Nice! This is something I've been wanting to add, but just haven't been too familiar with. |
Now I am just experimenting. When it will be ready - I will do a single commit :) |
Well, now it doesn't build examples and tests at all =( |
Haha ok 😄 |
0745e91
to
a6e0e4b
Compare
Script to avoid
Maybe you will see what to change here to fix it (now in checks only |
Ready to merge |
I've set threshold to 60% for now, when coverage will reach 80% - we'll set it to 80% I think. |
👍 excellent work! |
Excellent work will be when we hit 80% coverage. There is a lot of work now. And I'll start to implement some. The main problem is with false negative tests =( |
Do not merge