fix(derive)!: Rename Clap to Parser.
#2814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epage
commented
Oct 5, 2021
kbknapp
reviewed
Oct 5, 2021
|
The one failed CI check was a network error |
|
As I always said, instead of renaming, we should be creating the Parser
trait.
`Clap` is planned to be everything trait.
…On Tue, Oct 5, 2021, 17:08 Ed Page ***@***.***> wrote:
The one failed CI check was a network error
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#2814 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABKU33HQUAMATIUOBD3H7LUFMPJLANCNFSM5FL4QUNA>
.
|
pksunkara
requested changes
Oct 9, 2021
Before clap-rs#2005, `Clap` was a special trait that derived all clap traits it detected were relevant (including an enum getting both `ArgEnum`, `Clap`, and `Subcommand`). Now, we have elevated `Clap`, `Args`, `Subcommand`, and `ArgEnum` to be user facing but the name `Clap` isn't very descriptive. This also helps further clarify the relationships so a crate providing an item to be `#[clap(flatten)]` or `#[clap(subcommand)]` is more likely to choose the needed trait to derive. Also, my proposed fix fo clap-rs#2785 includes making `App` attributes almost exclusively for `Clap`. Clarifying the names/roles will help communicate this. For prior discussion, see clap-rs#2583
|
🕐 Waiting for PR status (Github check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set. |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before #2005,
Clapwas a special trait that derived all clap traits itdetected were relevant (including an enum getting both
ArgEnum,Clap, andSubcommand). Now, we have elevatedClap,Args,Subcommand, andArgEnumto be user facing but the nameClapisn'tvery descriptive. This is also important for explaining to the user why they would derive
Argsfor an enum in #2621.This also helps further clarify the relationships so a crate providing
an item to be
#[clap(flatten)]or#[clap(subcommand)]is more likelyto choose the needed trait to derive.
Also, my proposed fix fo #2785 includes making
Appattributes almostexclusively for
Clap. Clarifying the names/roles will helpcommunicate this.
For prior discussion, see #2583