fix(parser): Clean up remove types #3747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The remove functions no longer return `Arc` but the core type, at the cost of requiring `Clone`. I originally held off on this in clap-rs#3732 in the hope of gracefully transition the derive and requiring `Clone` would have been a breaking change but when it came to clap-rs#3734, I didn't find a way to make it work without a breaking change, so I made it opt-in. This means I can force the `Clone` requirement now. I added the requirement for `Clone` everywhere else in the hopes that in the future, we can drop the `Arc` without a breaking change.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The remove functions no longer return
Arcbut the core type, at thecost of requiring
Clone. I originally held off on thisin #3732 in the hope of gracefully transition the derive and requiring
Clonewould have been a breaking change but when it came to #3734, I didn'tfind a way to make it work without a breaking change, so I made it
opt-in. This means I can force the
Clonerequirement now.I added the requirement for
Cloneeverywhere else in the hopes that inthe future, we can drop the
Arcwithout a breaking change.