feat(derive): Reserve behavior needed for implicit ArgGroups #4209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epage
force-pushed
the
prep
branch
2 times, most recently
from
6781109
to
4868697
Compare
Since the `name` is changed to be the package name, we can't use it as (1) its not as predictable and (2) it can lead to conflicts if a `Parser` is flattened into a `Parser`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the building blocks for us to automatically create an
ArgGroupwhen derivingArgson a struct. This will make it easier to compose (write validation rules) particularly when the struct comes from a third party.The next step will then be to support deriving
Argson enums, see #2621