Fix buffering, seeked and playing events #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The _handleBufferingEvents should be override to avoid duplicated buffering/bufferfull events.
leandromoreira
approved these changes
Oct 8, 2020
jhonatangcavalcanti
force-pushed
the
feature/fix-buffering-and-play-events
branch
from
fa5c67a
to
a0fa6e2
Compare
jhonatangcavalcanti
changed the title
jhonatangcavalcanti
force-pushed
the
feature/fix-buffering-and-play-events
branch
from
a0fa6e2
to
a620320
Compare
leandromoreira
approved these changes
Oct 9, 2020
joaopaulovieira
approved these changes
Oct 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
bufferingandbufferfullevents were duplicated because thehtml5playback also handle them.This PR removes the triggers from
html5playback in favor ofbufferingevents from the shaka player.Besides that, the
playingandseekedevents are also fixed based on shaka-project/shaka-player#2230.There is also a new getter to allow access to the
shakalib fromDashShakaPlayback.