Introduce new package "automation" #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smyrman
force-pushed
the
automation
branch
5 times, most recently
from
61b347b
to
a1617d2
Compare
sarzhann
reviewed
Sep 28, 2022
sarzhann
reviewed
Oct 12, 2022
| // operations. | ||
| Verbose bool | ||
|
|
||
| // Out describe the destination writer for logs. If unset, all logging is |
There was a problem hiding this comment.
maybe write logs by default to stdout?
There was a problem hiding this comment.
Probably you mean Stderr. I did so initially. but it makes it harder to disable the logs, as you can't disable it by setting it to nil. Also, it's common in go to let logging be disabled by default in library packages.
E.g. if you have a program using structured logging (usually JSON), you would not want unstructured logs to end up among the output without you having actively enabled it.
There was a problem hiding this comment.
It's currently set by default in the automation template binary:
There was a problem hiding this comment.
Actually I meant stdout, but now I understand that it's best practice to log to stderr 👍
smyrman
commented
Oct 12, 2022
smyrman
commented
Oct 12, 2022
sarzhann
reviewed
Oct 12, 2022
sarzhann
reviewed
Oct 12, 2022
The new automation package is an utility package to allow setting up automations on top of Clarify. As a first automation type, we are adding a PublishSignals automation, which allow more easily publishing signals as items through a defined set of rules.
Update example to use new automation package. This greatly reduce the code-size for the publish signals example.
sarzhann
approved these changes
Oct 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used by https://github.com/clarify/template-clarify-automation (repo is private for now, but will be made public when PR is merged).
commit 3c085ed (HEAD -> automation, origin/automation)
Author: Sindre Myren sindre@clarify.io
Date: Wed Oct 12 14:28:23 2022 +0200
commit d8bf0b6
Author: Sindre Myren sindre@clarify.io
Date: Wed Oct 5 13:01:20 2022 +0200
commit 201d6f3
Author: Sindre Myren sindre@clarify.io
Date: Wed Oct 5 11:43:09 2022 +0200
commit efd5355
Author: Sindre Myren sindre@clarify.io
Date: Sun Sep 25 22:45:04 2022 +0200