48 increased regression test code coverage #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Increases coverage from 25% to 44%. Currently using CEC2 mixing code. Needs replacing with CEC1 mixing.
Now used CEC1 scene rendering code. Coverage increased from 44% to 47%.
Coverage increased from 47% to 53%
Note, this require torch, torchaudio and pystoi added as dependencies. The CEC1 and CEC2 pipeline regresion tests are now failing, i.e. producing significantly different haspi and mbstoi values! Need to investige why - rather odd as there has been no refactoring on this branch. Perhaps to with random number seeding?
Code using pytorch was using multiple threads which was causing problems for pytest. Adding torch.set_num_threads(1) to the test code appears to have fixed the problem. Coverage now at 58%.
- test_engine_losses - reduced precision of output so gives same result on all versions of python - test_CEC2_scene_builder - json output formatted on multiple lines so that diffs can be seen easily - test_full_CEC1_pipeline - fixed issue that tmp/ directory was not being created
- Using tempfile to tests sharing a tmp dir - Fixed full_CEC1_pipeline so produces a valid MBSTOI score
Coverage is currently 67% Test torch_stoi (extended version included) using randomly generated x and torch_msbg processed x; test for torchloudnorm (might not be used anywhere, but just in case)
…test-code-coverage-clarity/predictor Added regression test for clarity/predictor
coverage is currently 70% Warnings from HOA tools tests that use numba @njit decorator run via py_func calls due to deprecated handling of reflected lists.
Outputs are different in different machines, probably due to cuda issue, therefore round up to 5 digits
…test-code-coverage-clarity/predictor Change 0.8f to 0.5f in tests/regression/test_predictors
Merging main into 48-increased-regression-test-branch
…test-code-coverage 48 increased regression test code coverage
…test-code-coverage-clarity/enhancer 48 increased regression test code coverage clarity/enhancer
Codecov Report
@@ Coverage Diff @@
## main #62 +/- ##
===========================================
+ Coverage 25.54% 82.88% +57.33%
===========================================
Files 29 30 +1
Lines 3265 3353 +88
===========================================
+ Hits 834 2779 +1945
+ Misses 2431 574 -1857
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
jonbarker68
commented
Aug 12, 2022
jonbarker68
force-pushed
the
48-increased-regression-test-code-coverage
branch
from
55b3a03
to
7d78bed
Compare
TuZehai
approved these changes
Aug 12, 2022
60 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging the regression test branch back into main.