Adding dynamic routing and weather service #176
Conversation
saijel
changed the title
lucida/Makefile
Outdated
| @@ -1,3 +1,3 @@ | |||
| SUBDIRS=commandcenter imagematching questionanswering calendar speechrecognition djinntonic | |||
| SUBDIRS=commandcenter imagematching questionanswering calendar speechrecognition djinntonic weather | |||
There was a problem hiding this comment.
remove speechrecognition so its not built by default
There was a problem hiding this comment.
since chrome is going to be default its painful to build
|
|
||
| @abc.abstractmethod | ||
| def logic_method(self, response_data, service_graph, dcm_node): | ||
| """Decision making logic""" |
| self.create_query_spec('knowledge', [knowledge_input])) | ||
| transport.close() | ||
|
|
||
| # TODO: I need help trying to make this method look less scary |
There was a problem hiding this comment.
make this comment more descriptive what you would want to do (split into multiple functions, make a class) suggesting next that comes here has an idea.
| not_monument = 'cow' | ||
|
|
||
| class IMMDCM(Decision): | ||
|
|
There was a problem hiding this comment.
can you throw a doc string here describing a little what's going on. this is a template for DCM nodes so should be well documented.
There was a problem hiding this comment.
something like:
class IMMDCM(Decision):
"""
bla bla
"""
def logic_bla
| from Decision import* | ||
|
|
||
| class WEDCM(Decision): | ||
|
|
There was a problem hiding this comment.
same here on docstring. get into the habit of docstringing.
| @@ -0,0 +1,20 @@ | |||
| What's the weather here? | |||
There was a problem hiding this comment.
ha really creative training data 🥇
| image_file.write(data.c_str(), data.size()); | ||
| image_file.close(); | ||
| return image_path; | ||
| struct timeval tp; |
There was a problem hiding this comment.
fixes for IMM DB creation right?
There was a problem hiding this comment.
Yeah, the actual addition is on line 119 to convert images before pushing them to DB
| // if (pos != std::string::npos) res = img_name.substr(0, pos); | ||
| // res = res + ".pb"; | ||
| // return res; | ||
| // string res; |
There was a problem hiding this comment.
what's all this commented out code? maybe not you but if you know put a comment/
There was a problem hiding this comment.
no clue why these lines are commented, will delete
| // tess->End(); | ||
| // // TODO: add some preprocessing for a bounding box | ||
| // | ||
| // tesseract::TessBaseAPI *tess = new tesseract::TessBaseAPI(); |
There was a problem hiding this comment.
what's all this commented code? if you don't know why its there lets remove
lucida/weather/WeatherConfig.py
Outdated
| # Open Weather Map API key | ||
| # https://openweathermap.org/api | ||
| OWM_API_URL_BASE = 'http://api.openweathermap.org/data/2.5/weather?' | ||
| OWM_API_KEY = '362537b891e6df03a316e82565fe4df3' # TODO: remove after PR has been accepted # add your API key here |
There was a problem hiding this comment.
Noted. have your own branch that across all the MRs applies your keys. keep rebasing and applying that branch to master.
Creating new PR that was based off of #169.
List of changes: