Skip to content
This repository has been archived by the owner on Mar 24, 2019. It is now read-only.

Question: Why is the "material" property on a IBodyOptions of type "number"? #6

Closed
nicky-lenaers opened this issue Aug 22, 2016 · 3 comments

Comments

@nicky-lenaers
Copy link

Hi,

First of all thanks for the definition files, they help a lot.

I'm trying to create a CANNON.Body with shape and material properties set. However, I noticed that material is typed as a number (see here). In all examples I can find it references a CANNON.Material instance (see here for example).

Also, the CANNON.js Docs refer to a CANNON.Material instance on the CANNON.Body options.

Is this correct or am I missing something?

@nicky-lenaers
Copy link
Author

@clark-stevenson Care to comment?

@clark-stevenson
Copy link
Owner

Sorry Nicky my man, I made the change on Friday but forgot to commit.

Keep in mind that the accuracy of these definitions may be somewhat outdated. I wrote them a good year ago, but the project was abandoned before I could use them. I would welcome any other changes as PR's if you find them. Otherwise let me know any other issues.

Thanks!

@nicky-lenaers
Copy link
Author

@clark-stevenson Thanks a lot, didn't mean to put pressure on it! I will keep an eye out for any API changes and contribute here =). The CANNON.js repo is still in development, right?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants