Fix field 'required' behavior to match DRF #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Non-required fields with None values are now omitted from the serialization. Also required MethodFields with None value trigger an exception now.
|
@clarkduvall any chance that either this or #25 could be merged in? I've been running a local fork for a while because serpy will blow up if it encounters an object with a missing key. It would be great to be able to bring it back to the main repo. |
|
This looks good, sorry for the (super long) delay. I'll try to do a release sometime today with this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Non-required fields with None values are now omitted from the
serialization. Also required MethodFields with None value trigger
an exception now.